Logo (Builtin): adds Quasar Linix logo

[f-jooste]

Summary

Added Quasar Linux logo

Related issue:

Resolves #2323

Changes

• added ascii file to src/logo/ascii/quasar.txt
• added section in src/logo/builtin.c

Screenshots

Checklist

• I have tested my changes locally.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 1 duplication

Metric	Results
Complexity	0
Duplication	1

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

The PR successfully registers the Quasar Linux logo in the builtin registry. While the implementation follows the expected logic, there are minor styling inconsistencies in the data structure and a typo in the PR title ('Linix' instead of 'Linux'). Additionally, no unit or integration tests were provided to verify the logo selection or color rendering, leaving an implementation gap regarding verification.

About this PR

• No unit or integration tests were added to verify the new logo registration or its rendering. This makes it difficult to ensure the 'Quasar' key correctly maps to the intended ASCII art and colors.
• The PR title contains a typo: 'Linix' instead of 'Linux'.

Test suggestions

• Verify that 'Quasar' logo can be selected by name and displays the content of quasar.txt.
• Verify that the logo colors (White) and key colors (Blue) are correctly applied when the logo is rendered.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify that 'Quasar' logo can be selected by name and displays the content of quasar.txt.
2. Verify that the logo colors (White) and key colors (Blue) are correctly applied when the logo is rendered.

Low confidence findings

• The constant FASTFETCH_DATATEXT_LOGO_QUASAR is referenced in src/logo/builtin.c but its definition is not visible in the current diff. Please ensure it is correctly defined or generated.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{⚪ LOW RISK}

Nitpick: The indentation here is inconsistent with the surrounding code (should be aligned to 12 spaces) and the project style for array elements. Adding a trailing comma is also recommended for consistency with other logo definitions.

Suggested change

	FF_COLOR_FG_WHITE
	FF_COLOR_FG_WHITE,

[codacy-production]

Pull Request Overview

This PR is currently incomplete and should not be merged in its present state. Although the title indicates the addition of the Quasar Linux logo, the required ASCII art file (src/logo/ascii/quasar.txt) is missing from the diff. Consequently, the registration in src/logo/builtin.c is referencing a non-existent asset, failing to meet the primary acceptance criteria.

About this PR

• The implementation is incomplete. The required file src/logo/ascii/quasar.txt was not included in the PR, which is necessary for the Quasar Linux logo integration to function.
• There is a typo in the PR title ('Linix' instead of 'Linux').

Test suggestions

• Verify that the ASCII art in src/logo/ascii/quasar.txt is formatted correctly and matches the expected Quasar Linux branding.
• Verify that src/logo/builtin.c correctly references the new Quasar ASCII file and is accessible via the program's logo selection logic.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify that the ASCII art in src/logo/ascii/quasar.txt is formatted correctly and matches the expected Quasar Linux branding.
2. Verify that src/logo/builtin.c correctly references the new Quasar ASCII file and is accessible via the program's logo selection logic.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}