JsonSchema: correct references for keyboard, mouse items #2119
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
3ventic
commented
Dec 26, 2025
3ventic
commented
- corrected format references from memoryFormat to keyboardFormat and mouseFormat respectively
- added outputColor to both since it appears to be supported for keyboard and mouse items too
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects schema definition errors for keyboard and mouse items in the JSON schema. The keyboard and mouse items were incorrectly referencing memoryFormat instead of their appropriate format definitions, and were missing the outputColor property that is supported by these modules.
- Fixed incorrect format reference for keyboard item (from
memoryFormattokeyboardFormat) - Fixed incorrect format reference for mouse item (from
memoryFormattomouseFormat) - Added
outputColorproperty support to both keyboard and mouse items
Contributor
Author
|
Thank you Copilot for this anti-summary |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.