fix: beta feedback batch 2 — metadata, naming, delete confirm, persistence, race condition#1
Open
fix: beta feedback batch 2 — metadata, naming, delete confirm, persistence, race condition#1
Conversation
- Acq_ID supports leading zeros (text input + smart increment) (#903) - Sample_ID as string + save confirmation snackbar (#889-893) - Show project/sample/operator/gear in acquisition page (#894) - Add flowcell size (µm) to magnification button labels (#901)
- Compose fully-qualified project_sample_acq IDs in update_config (#882) - Space-to-underscore sanitization in IDs - Gallery + Explorer URL path sanitization for legacy TSVs
- Replace direct deleteItem with confirmDelete + dialog - Show acquisition and sample ID in confirmation prompt - Warning that deletion cannot be undone
- set object_datetime also persists lat/lon if present - set object_latlon also persists date/time if present
The start acquisition function read acq_nb_frame and acq_interframe_volume from Node-RED globals, but the globals were written by a parallel message path. When the user changed form values and clicked Start, the read happened before the write, causing the acquisition to use stale values. Fix: start acquisition now reads from msg.payload first (carried with the command), falling back to globals for backwards compatibility. handleAcqStatusChange explicitly passes acq values in the start message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five fixes for issues found during beta testing:
on acquisition page, flowcell size on magnification labels
sanitization
relying on globals, preventing stale values when the user changes form fields and immediately clicks Start