Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
This adds caching for HTTP API failures when fetching PLC documents and FAIR metadata. The DID is used in the cache key and the timeout for each is one hour.
The corresponding error message is shown below each plugin on the Plugins screen with information about how long it will be until the next update check for that plugin.
Testing steps
You'll see the correesponding HTTP API error message below any FAIR-enabled plugins.
Effects
If plc.directory goes down, FAIR Connect will cache the HTTP API failure for any plugins that trigger an update check. This is intentional, it helps prevent the effects reported in the linked issue.
If the FAIR metadata service endpoint for an individual plugin goes down, FAIR Connect will cache the HTTP API failure and won't perform an update check for that plugin for the next hour, even if update checks are performed during that period for other FAIR connected plugins.
Screenshots
Network failure
Airplane mode active
Any HTTP API error message