Fix data race in POOL_create_advanced by protecting threadLimit #4558
Conversation
Fixes a potential data race in `POOL_create_advanced` where `ctx->threadLimit` was being updated without holding the `queueMutex`. Worker threads (`POOL_thread`) could access `threadLimit` before it was fully initialized, leading to undefined behavior. The update to `ctx->threadLimit` is now mutex-protected to ensure thread safety during initialization. `ctx->threadCapacity` remains unprotected, as it is only modified by the parent thread during setup.
|
Hi @richardsonnick! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Fixes a potential data race in
POOL_create_advancedwherectx->threadLimitwas being updated without holding thequeueMutex. Worker threads could accessthreadLimitbefore it was fully initialized, leading to undefined behavior.The update to
ctx->threadLimitis now protected by thectx->queueMutexto ensure thread safety during initialization.ctx->threadCapacityremains unprotected, as it is only modified by the parent thread during setup.Fix for #4547