Add configurable logging shim#252
Open
afrind wants to merge 1 commit into
Open
Conversation
Summary: Introduces `wangle/util/Logging.h`, a header-only macro layer that lets downstream builds choose at compile time which backend services log emission: - `WANGLE_LOGGING_GLOG=1` (default) — glog via `<folly/GLog.h>`. Behavior identical to today. - `WANGLE_LOGGING_FOLLY_LOGGING=1` — folly::xlog via `<folly/logging/xlog.h>`. Routes through folly's category tree. - `WANGLE_LOGGING_DISABLED=1` — fully stripped. `WANGLE_CHECK` -> `if (!e) abort()`, `WANGLE_DCHECK` -> `assert(e)`, log streams become a noop sink. The pattern is borrowed from `fizz/util/Logging.h`. The default is glog because every existing wangle call site uses glog today; opting in to xlog or noop lets OSS users ship without a glog dependency. All ~370 wangle log/check call sites converted to the `WANGLE_*` macros via codemod. Two `VLOG(10)` sites lowered to `VLOG(9)` so folly-logging mode compiles (folly only defines `DBG0..DBG9`). CMake/getdeps integration mirrors the BUCK story: `wangle/CMakeLists.txt` exposes the modes as `option()`s and propagates the macro state via `target_compile_definitions(wangle_util_logging INTERFACE ...)`. Per-subdir `CMakeLists.txt` regenerated by `wangle/facebook/generate_cmake.py`. Differential Revision: D106528033
|
@afrind has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106528033. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces
wangle/util/Logging.h, a header-only macro layer that lets downstream builds choose at compile time which backend services log emission:WANGLE_LOGGING_GLOG=1(default) — glog via<folly/GLog.h>. Behavior identical to today.WANGLE_LOGGING_FOLLY_LOGGING=1— folly::xlog via<folly/logging/xlog.h>. Routes through folly's category tree.WANGLE_LOGGING_DISABLED=1— fully stripped.WANGLE_CHECK->if (!e) abort(),WANGLE_DCHECK->assert(e), log streams become a noop sink.The pattern is borrowed from
fizz/util/Logging.h. The default is glog because every existing wangle call site uses glog today; opting in to xlog or noop lets OSS users ship without a glog dependency.All ~370 wangle log/check call sites converted to the
WANGLE_*macros via codemod. TwoVLOG(10)sites lowered toVLOG(9)so folly-logging mode compiles (folly only definesDBG0..DBG9).CMake/getdeps integration mirrors the BUCK story:
wangle/CMakeLists.txtexposes the modes asoption()s and propagates the macro state viatarget_compile_definitions(wangle_util_logging INTERFACE ...). Per-subdirCMakeLists.txtregenerated bywangle/facebook/generate_cmake.py.Differential Revision: D106528033