[compiler] Allow setState after await in effect callbacks#36417
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
[compiler] Allow setState after await in effect callbacks#36417raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set-state-in-effecttreats callbacks invoked directly by an effect as synchronous. That is correct until an async callback reaches anawait: code after that point runs in a later continuation and should not be reported as synchronous setState inside the effect body.This adds a small must-analysis for async HIR functions to identify instructions that are definitely after an awaited boundary. Calls to a state setter after that point are ignored, while calls before the first
awaitstill report.Fixes #34905
How did you test this change?
corepack yarn --cwd packages/eslint-plugin-react-hooks build:compilercorepack yarn --cwd packages/eslint-plugin-react-hooks jest ReactCompilerRuleTypescript-test --runInBandcorepack yarn --cwd packages/eslint-plugin-react-hooks typecheckgit diff --check