[DevTools] Preserve -0 in inspected values#36407
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
[DevTools] Preserve -0 in inspected values#36407raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DevTools already preserves lossy primitive values like
Infinity,-Infinity,NaN, andundefinedwhen inspected values cross the bridge. This adds the same handling for-0, which otherwise gets serialized and displayed as0.This updates:
-0Tests
git diff --checkI also attempted the focused DevTools Jest path locally, but the build required by
--project devtools --buildcould not be produced in this Windows shell becausecorepack yarn build-for-devtoolsexits while invoking the repository's POSIX shell prebuild script.