Add enableViewTransitionForPersistenceMode feature flag#36014
Open
zeyap wants to merge 1 commit intofacebook:mainfrom
Open
Add enableViewTransitionForPersistenceMode feature flag#36014zeyap wants to merge 1 commit intofacebook:mainfrom
zeyap wants to merge 1 commit intofacebook:mainfrom
Conversation
Wherever the reconciler checks supportsMutation before running view transition logic, add an else-if branch gated on enableViewTransitionForPersistenceMode for persistent renderers (Fabric). This follows the pattern that supportsMutation guards mutation-mode-only logic, and persistent mode should have its own branch rather than being lumped under a single supportsViewTransition capability flag. For now the persistent mode branches duplicate the mutation logic. The flag defaults to false in all channels.
|
Comparing: 7b5b561...bf9744b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableViewTransitionForPersistenceModefeature flag (defaults tofalsein all channels)supportsMutationbefore running view transition logic, adds anelse if (enableViewTransitionForPersistenceMode)branch for persistent renderers (Fabric)supportsMutationguards mutation-mode-only logic, and persistent mode should have its own branch rather than being lumped under a singlesupportsViewTransitioncapability flagReactFiberCommitViewTransitions.js:applyViewTransitionToHostInstancesRecursiverestoreViewTransitionOnHostInstancesmeasureViewTransitionHostInstancesRecursiveReactFiberCommitWork.js:restoreRootViewTransitionNamein passive mount for HostRootTest plan
falseby default, so no behavior change)yarn flowfor dom-node, fabric, native renderers