[Compiler] Fix overloads causing wrong function export with gating#36013
[Compiler] Fix overloads causing wrong function export with gating#36013GokhanKabar wants to merge 1 commit intofacebook:mainfrom
Conversation
TypeScript overload signatures (TSDeclareFunction nodes) were causing getFunctionReferencedBeforeDeclarationAtTopLevel to falsely detect functions as referenced before their declaration. This triggered the hoisting code path which placed the export on the unoptimized variant instead of the dispatcher function. Fix: Skip TSDeclareFunction nodes in the reference-before-declaration traversal, consistent with how other type-only nodes (TypeAnnotation, TSTypeAnnotation, TypeAlias, TSTypeAliasDeclaration) are already skipped. Fixes facebook#35991
|
Hi @GokhanKabar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
TypeScript overload signatures (TSDeclareFunction nodes) were causing getFunctionReferencedBeforeDeclarationAtTopLevel to falsely detect functions as referenced before their declaration. This triggered the hoisting code path which placed the export on the unoptimized variant instead of the dispatcher function.
Fix: Skip TSDeclareFunction nodes in the reference-before-declaration traversal, consistent with how other type-only nodes (TypeAnnotation, TSTypeAnnotation, TypeAlias, TSTypeAliasDeclaration) are already skipped.
Fixes #35991