[enableInfiniteRenderLoopDetection] Warn about potential infinite loop, instead of interrupting#35999
Open
[enableInfiniteRenderLoopDetection] Warn about potential infinite loop, instead of interrupting#35999
Conversation
|
Comparing: 014138d...ea77284 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
hoxyq
force-pushed
the
reconciler/warn-about-potential-infinite-render-loop
branch
from
1675545 to
6f027a3
Compare
…p, instead of interrupting
hoxyq
force-pushed
the
reconciler/warn-about-potential-infinite-render-loop
branch
from
6f027a3 to
ea77284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
enableInfiniteRenderLoopDetectionfeature flag is currently disabled everywhere. When attempted to roll out this at Meta, we've observed multiple false-positives, where counter-based approach would interrupt the render that would've resolved at some later iteration.This change gates the scenarios that are only discovered with the instrumentation behind
enableInfiniteRenderLoopDetectionflag to warn about potential infinite loop, instead of throwing an error and hitting an error boundary. The main reason is to see if we can a signal on which possible area of scenarios this new approach to infinite loops covers.The gist of the approach is to ensure that we are still throwing error and breaking the infinite loop, if we were doing this without
enableInfiniteRenderLoopDetectionfeature flag enabled.This will log multiple errors if there is an infinite loop, but this should be fine, and it also aligns with the pattern for warnings about passive effects infinite loop.
I've validated that tests in
ReactUpdates-test.jsare passing independently whether the feature flag is enabled or not.