[Flight] Fix stack overflow in visitAsyncNode with deep async chains
#35612
+566
−317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database libraries like Gel/EdgeDB can create very long linear chains of async sequences through temporal async sequencing in connection pools. The recursive traversal of
node.previouschains invisitAsyncNodecauses stack overflow on these deep chains.The fix converts the
previouschain traversal from recursive to iterative. We collect the chain into an array, then process from deepest to shallowest.The
awaitedtraversal remains recursive since its depth is bounded by promise dependency depth, not by the number of event loop turns. Eachawaitedbranch still benefits from the iterativeprevioushandling within its own traversal.I've verified that this fixes the repro provided in #35246.
closes #35246