[wip][compiler] Support optional/logical/etc within try/catch #35606
+1,172
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
josephsavona
changed the title
josephsavona
force-pushed
the
worktree-2026-01-22-11-41-02-orange-river
branch
2 times, most recently
from
ffa4d6e to
79e188d
Compare
josephsavona
commented
Jan 24, 2026
| {obj: {method: () => 'different'}}, | ||
| {obj: {method: null}}, | ||
| {obj: {notMethod: true}}, | ||
| {obj: null}, |
Member
Author
There was a problem hiding this comment.
needs a variant that throws. maybe obj?.method?.(obj.foo) so that this throws if obj == null
josephsavona
commented
Jan 24, 2026
| {a: null, b: null, c: 'third'}, | ||
| {a: undefined, b: undefined, c: 'fallback'}, | ||
| {a: 0, b: 'not zero', c: 'third'}, | ||
| {a: '', b: 'not empty', c: 'third'}, |
Member
Author
There was a problem hiding this comment.
add a variant that throws: replace ?? c with ?? throwError(c)
josephsavona
force-pushed
the
worktree-2026-01-22-11-41-02-orange-river
branch
from
79e188d to
20c7514
Compare
Control-flow expressions such as logicals, optionals, and ternaries were not supported within try/catch. BuildReactiveFunction recursively traversed these terminals, and was not expecting their condition blocks to end in a maybe-throw terminal, which can occur due to the try/catch. The fix here is to treat the maybe-throw similarly to goto, passing through to the continuation block.
josephsavona
force-pushed
the
worktree-2026-01-22-11-41-02-orange-river
branch
from
20c7514 to
b58f60f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control-flow expressions such as logicals, optionals, and ternaries were not supported within try/catch. BuildReactiveFunction recursively traversed these terminals, and was not expecting their condition blocks to end in a maybe-throw terminal, which can occur due to the try/catch. The fix here is to treat the maybe-throw similarly to goto, passing through to the continuation block.
I added some more tests and realized this has issues, still iterating