Skip to content

[WIP] use symbols for scheduler priority levels #35588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elevenpassin wants to merge 4 commits into
base: main
Choose a base branch
from
+30 −8
Draft

[WIP] use symbols for scheduler priority levels #35588

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b35d6c
use symbols for scheduler priority levels
elevenpassin Jan 21, 2026
68d795f
remove unnecessary type casting
elevenpassin Jan 21, 2026
8cc5366
Merge branch 'main' into no-ticket-use-symbols-for-scheduler-priority…
elevenpassin Jan 21, 2026
24c0799
Merge branch 'main' into no-ticket-use-symbols-for-scheduler-priority…
elevenpassin Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions packages/scheduler/src/SchedulerPriorities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,34 @@
* @flow strict
*/

export type PriorityLevel = 0 | 1 | 2 | 3 | 4 | 5;
export opaque type NoPriorityType: symbol = symbol;
export opaque type ImmediatePriorityType: symbol = symbol;
export opaque type UserBlockingPriorityType: symbol = symbol;
export opaque type NormalPriorityType: symbol = symbol;
export opaque type LowPriorityType: symbol = symbol;
export opaque type IdlePriorityType: symbol = symbol;

// TODO: Use symbols?
export const NoPriority = 0;
export const ImmediatePriority = 1;
export const UserBlockingPriority = 2;
export const NormalPriority = 3;
export const LowPriority = 4;
export const IdlePriority = 5;
export const NoPriority: NoPriorityType = Symbol.for('scheduler.no_priority');
export const ImmediatePriority: ImmediatePriorityType = Symbol.for(
'scheduler.immediate_priority',
);
export const UserBlockingPriority: UserBlockingPriorityType = Symbol.for(
'scheduler.user_blocking_priority',
);
export const NormalPriority: NormalPriorityType = Symbol.for(
'scheduler.normal_priority',
);
export const LowPriority: LowPriorityType = Symbol.for(
'scheduler.low_priority',
);
export const IdlePriority: IdlePriorityType = Symbol.for(
'scheduler.idle_priority',
);

export type PriorityLevel =
| NoPriorityType
| ImmediatePriorityType
| UserBlockingPriorityType
| NormalPriorityType
| LowPriorityType
| IdlePriorityType;