Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 21, 2026

Partially types the message protocol in the content scripts.

The downside is a false sense of safety because we have to restrict the received events to known events. Extending the received events to all possible events would not allow type narrowing.

@meta-cla meta-cla bot added the CLA Signed label Jan 21, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 21, 2026
@react-sizebot
Copy link

Comparing: b546603...9011a5b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.01% 608.67 kB 608.73 kB +0.01% 107.63 kB 107.65 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.60 kB 674.66 kB +0.01% 118.58 kB 118.59 kB
facebook-www/ReactDOM-prod.classic.js = 694.04 kB 694.11 kB +0.01% 122.01 kB 122.02 kB
facebook-www/ReactDOM-prod.modern.js = 684.43 kB 684.50 kB +0.02% 120.40 kB 120.42 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js +0.71% 12.75 kB 12.84 kB +0.78% 2.71 kB 2.73 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js +0.71% 12.75 kB 12.84 kB +0.78% 2.71 kB 2.73 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js +0.71% 12.75 kB 12.84 kB +0.78% 2.71 kB 2.73 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js +0.59% 11.29 kB 11.36 kB +0.65% 2.63 kB 2.65 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js +0.59% 11.29 kB 11.36 kB +0.65% 2.63 kB 2.65 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js +0.59% 11.29 kB 11.36 kB +0.65% 2.63 kB 2.65 kB

Generated by 🚫 dangerJS against 9011a5b

@eps1lon eps1lon requested a review from hoxyq January 21, 2026 15:19
@eps1lon eps1lon marked this pull request as ready for review January 21, 2026 15:19
@eps1lon eps1lon merged commit cdbd55f into facebook:main Jan 21, 2026
249 checks passed
@eps1lon eps1lon deleted the sebbie/01-21-type_react-devtools-hook-installer_and_react-devtools-hook-settings-injector_messages branch January 21, 2026 18:13
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 25, 2026
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants