Skip to content

Remove --version spawn from debugger shell preparation #56706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −19
Open

Remove --version spawn from debugger shell preparation #56706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions packages/debugger-shell/src/node/index.flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@
* @format
*/

import {
prepareDebuggerShellFromDotSlashFile,
spawnAndGetStderr,
} from './private/LaunchUtils';
import {prepareDebuggerShellFromDotSlashFile} from './private/LaunchUtils';

const {spawn} = require('cross-spawn');
const debug = require('debug')('Metro:DebuggerShell');
Expand Down Expand Up @@ -174,20 +171,6 @@ async function unstable_prepareDebuggerShell({
throw new Error(`Unknown flavor: ${flavor}`);
}

const [binaryPath, baseArgs] = getShellBinaryAndArgs(
flavor,
prebuiltBinaryPath,
);
const {code, stderr} = await spawnAndGetStderr(binaryPath, [
...baseArgs,
'--version',
]);
if (code !== 0) {
return {
code: 'unexpected_error',
verboseInfo: stderr,
};
}
return {code: 'success'};
} catch (e) {
return {
Expand Down
2 changes: 1 addition & 1 deletion packages/debugger-shell/src/node/private/LaunchUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,4 @@ async function prepareDebuggerShellFromDotSlashFile(
};
}

export {spawnAndGetStderr, prepareDebuggerShellFromDotSlashFile};
export {prepareDebuggerShellFromDotSlashFile};
Loading