[Hermes][CI] Remove dual Hermes version outputs from CI workflows#56704
Draft
cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase4from
Draft
[Hermes][CI] Remove dual Hermes version outputs from CI workflows#56704cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase4from
cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase4from
Conversation
Simplify publish-release, create-draft-release, and prebuild-ios-core workflows to use a single HERMES_VERSION. Remove the Hermes V1 dSYM section from release notes. Delete unused prepare-hermes-v1-app action, hermes-v1.patch, and selectLatestHermesV1Version.js.
meta-cla
Bot
added
the
CLA Signed
cipolleschi
changed the title
|
Caution Invalid Base Branch The base branch for this PR is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-release.yml: removeHERMES_V1_VERSIONoutput, read onlyHERMES_VERSION_NAMEcreate-draft-release.yml: removehermesV1VersioninputcreateDraftRelease.js: removehermesV1Versionparameter and "Hermes V1 dSYMS" section from release notesprebuild-ios-core.yml: readHERMES_VERSION_NAMEinstead ofHERMES_V1_VERSION_NAMEprepare-hermes-v1-appaction,hermes-v1.patch, andselectLatestHermesV1Version.jsChangelog:
[Internal]
Test plan
yarn jest --no-watchman createDraftRelease-test.js— 9/9 tests pass