[Hermes][Android] Remove hermesV1Enabled Gradle property and simplify Hermes version resolution#56700
Draft
cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase1from
Conversation
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
meta-cla
Bot
added
the
CLA Signed
|
Caution Invalid Base Branch The base branch for this PR is |
cipolleschi
changed the title
cipolleschi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermesV1Enabled/react.hermesV1EnabledGradle property and all branching it controlsHERMES_V1_VERSION_NAMEtoHERMES_VERSION_NAMEinversion.propertieshermesV1EnabledfromPrivateReactExtension,ProjectUtils,PropertyUtils,ReactPluginDependencyUtils.Coordinatesto single Hermes version-DHERMESVM_HEAP_HV_MODE=HEAP_HV_PREFER32CMake flag unconditional-DHERMES_V1_ENABLED=1CMake argument fromReactAndroidand Fantom buildshermesV1Enabled=truefromgradle.propertiesChangelog:
[Android][Removed] - Remove hermesV1Enabled and simplify the code
Test plan
./gradlew -p packages/gradle-plugin build— BUILD SUCCESSFUL, all tests pass./gradlew :packages:rn-tester:android:app:assembleDebug— BUILD SUCCESSFUL