[Hermes] Remove legacy Hermes C++ code and HERMES_V1_ENABLED compile definition#56697
Draft
cipolleschi wants to merge 1 commit intomainfrom
Draft
[Hermes] Remove legacy Hermes C++ code and HERMES_V1_ENABLED compile definition#56697cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
Legacy Hermes support is no longer needed since 0.86 branch has been cut. This removes all dead code behind `!defined(HERMES_V1_ENABLED)` guards and the CMake infrastructure that set the HERMES_V1_ENABLED compile definition.
meta-cla
Bot
added
the
CLA Signed
cipolleschi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!defined(HERMES_V1_ENABLED)guards inHermesExecutorFactory.cppandHermesInstance.cppRegistration.h,Registration.cpp,ConnectionDemux.h,ConnectionDemux.cpp, andConnectionDemuxTests.cpp(entirely legacy code)HERMES_V1_ENABLEDcompile definition fromreact-native-flags.cmakeHERMES_V1_ENABLEDcache variable from AndroidCMakeLists.txtThis is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code
is dead and can be safely removed.
Changelog:
[General][Breaking] - Remove Legacy Hermes from C++ code
Test plan
./gradlew :packages:rn-tester:android:app:assembleDebug— BUILD SUCCEEDEDxcodebuildrn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED