Add header_mappings_dir to React-Fabric.podspec animated subspec#56151
Open
zoontek wants to merge 1 commit intofacebook:mainfrom
Open
Add header_mappings_dir to React-Fabric.podspec animated subspec#56151zoontek wants to merge 1 commit intofacebook:mainfrom
zoontek wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
thanks for fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When building React Native (
0.85.0-rc.5) core from source (RCT_USE_PREBUILT_RNCORE=0), theReact-Fabric/animatedCocoaPods subspec flattens theevent_drivers/subdirectory headers becauseheader_mappings_diris not set.CocoaPods'
header_dirwithoutheader_mappings_dirplaces all matched headers directly under the specified directory, losing any subdirectory structure. This meansevent_drivers/EventAnimationDriver.hends up atreact/renderer/animated/EventAnimationDriver.hinstead ofreact/renderer/animated/event_drivers/EventAnimationDriver.h.The
#includeinNativeAnimatedNodesManager.hexpects the full path with theevent_drivers/subdirectory, so the build fails with:This doesn't affect prebuilt (
RCT_USE_PREBUILT_RNCORE=1) builds because the xcframework ships with a VFS overlay that maps headers correctly.The fix adds
header_mappings_dirto theanimatedsubspec inReact-Fabric.podspec, which tells CocoaPods to preserve the directory structure relative toreact/renderer/animated.Changelog:
[IOS] [FIXED] - Fix
EventAnimationDriver.hnot found when building React Native from source due to missingheader_mappings_dirinReact-Fabric/animatedpodspecTest Plan:
RCT_USE_PREBUILT_RNCORE=0in your Podfilepod install'react/renderer/animated/event_drivers/EventAnimationDriver.h' file not found