AccessibilityInfo: added missing tests for Promise based methods, align null checks and error message code style #56150
Open
chicio wants to merge 9 commits intofacebook:mainfrom
Open
AccessibilityInfo: added missing tests for Promise based methods, align null checks and error message code style #56150chicio wants to merge 9 commits intofacebook:mainfrom
chicio wants to merge 9 commits intofacebook:mainfrom
Conversation
…vertColorsEnabled
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR continue the work I'm doing to improve the
AccessibilityInfomodule (#56066 and connected PRs).In this new PR I added the missing tests for all the Promise based methods in the
AccessibilityInfo, to prevent regressions similar to those fixed in the previous PRs.This PR also includes a couple of small code style consistency improvement:
getRecommendedTimeoutMillisto the other ones already present in the fileisGrayscaleEnabled,isInvertColorsEnabledandisReduceMotionEnabledto the other onesChangelog:
[GENERAL] [ADDED] - AccessibilityInfo: added missing tests for Promise based methods, align null checks and error message code style
Test Plan:
I run the tests that I added to verify their correctness. Some of them were failing because of the change of the error messages, and I made them green by changing the message in the production code. For this others, I verified their correctness by breaking the production code to see if they were failing.