Add eventCount property to TextInputKeyPressEventData type#56065
Open
pchalupa wants to merge 1 commit intofacebook:mainfrom
Open
Add eventCount property to TextInputKeyPressEventData type#56065pchalupa wants to merge 1 commit intofacebook:mainfrom
eventCount property to TextInputKeyPressEventData type#56065pchalupa wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Contributor
Author
This PR adds a property. I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Align
TextInputKeyPressEventDatatype with:react-native/packages/react-native/Libraries/Components/TextInput/TextInput.flow.js
Line 103 in 116ea59
TextInputKeyPressEventDatawas missing theeventCountin the event payload.Changelog:
[GENERAL] [FIXED] - Add eventCount to TextInputKeyPressEventData type
Test Plan:
Check fabric event emitter:
react-native/packages/react-native/ReactCommon/react/renderer/components/textinput/TextInputEventEmitter.cpp
Line 113 in 618ef02