Skip to content

Add eventCount property to TextInputKeyPressEventData type#56065

Open
pchalupa wants to merge 1 commit intofacebook:mainfrom
pchalupa:add-event-count-property
Open

Add eventCount property to TextInputKeyPressEventData type#56065
pchalupa wants to merge 1 commit intofacebook:mainfrom
pchalupa:add-event-count-property

Conversation

@pchalupa
Copy link
Contributor

@pchalupa pchalupa commented Mar 11, 2026

Summary:

Align TextInputKeyPressEventData type with:


TextInputKeyPressEventData was missing the eventCount in the event payload.

Changelog:

[GENERAL] [FIXED] - Add eventCount to TextInputKeyPressEventData type

Test Plan:

Check fabric event emitter:

payload.setProperty(runtime, "eventCount", keyPressMetrics.eventCount);

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2026
@github-actions
Copy link

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: BREAKING

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 11, 2026
@pchalupa
Copy link
Contributor Author

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: BREAKING

This PR adds a property. I think BREAKING is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants