Refactor serverBaseUrl from string to URL object #55285
Open
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90987090. |
Summary: Pull Request resolved: facebook#55285 Changelog: [GENERAL] [CHANGED] - `createDevMiddleware` now accepts `string | URL` for `serverBaseUrl` Replaces the serverBaseUrl string type with a native URL object across the Metro CLI and Gateway packages. This change improves type safety and makes URL manipulation more robust by leveraging the built-in URL API instead of string concatenation. The public createDevMiddleware API has been updated to accept either a string or URL for the serverBaseUrl option. Internally within the dev-middleware package, the internal APIs (InspectorProxy, openDebuggerMiddleware, getDevToolsFrontendUrl) use URL objects instead of strings. https://www.npmjs.com/package/react-native/dev-middleware Reviewed By: vzaidman Differential Revision: D90987090
emily8rown
force-pushed
the
export-D90987090
branch
from
1bfbe74 to
22f4ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [GENERAL] [CHANGED] -
createDevMiddlewarenow acceptsstring | URLforserverBaseUrlReplaces the serverBaseUrl string type with a native URL object across the Metro CLI and Gateway packages.
This change improves type safety and makes URL manipulation more robust by leveraging the built-in URL API instead of string concatenation.
The public createDevMiddleware API has been updated to accept either a string or URL for the serverBaseUrl option.
Internally within the dev-middleware package, the internal APIs (InspectorProxy, openDebuggerMiddleware, getDevToolsFrontendUrl) use URL objects instead of strings.
https://www.npmjs.com/package/react-native/dev-middleware
Reviewed By: vzaidman
Differential Revision: D90987090