Skip to content

[Android] Fix TextInput placeholder multiline #55272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delphinebugner wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

[Android] Fix TextInput placeholder multiline #55272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ve/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import android.text.InputFilter.LengthFilter
import android.text.InputType
import android.text.Layout
import android.text.SpannableStringBuilder
import android.text.TextUtils
import android.view.Gravity
import android.view.KeyEvent
import android.view.View
Expand Down Expand Up @@ -372,6 +373,9 @@ public open class ReactTextInputManager public constructor() :
@ReactProp(name = "placeholder")
public fun setPlaceholder(view: ReactEditText, placeholder: String?) {
view.setPlaceholder(placeholder)
if (view.stagedInputType != InputType.TYPE_TEXT_FLAG_MULTI_LINE) {
view.setEllipsize(TextUtils.TruncateAt.END);
}
}

@ReactProp(name = "placeholderTextColor", customType = "Color")
Expand Down