fix: reset listenerCount when invalidating RCTEventEmitter

[brainbicycle]

Summary:

If a subclass of RCTEventEmitter outlives the bridge and the bridge is invalidated, the invalidate method is called on RCTEventEmitter which calls stopObserving but does not change the listenerCount. Once the bridge is recreated and a listener added to the RCTEventEmitter if the listenerCount is > 1 startListening is never called:

react-native/packages/react-native/React/Modules/RCTEventEmitter.m

Line 109 in a9a0268

if (_listenerCount == 1) {

This just resets the listenerCount to prevent this.

Probably not a good idea to have modules that outlive bridge in first place but this seems like unwanted behavior in any case :).

Changelog:

[iOS] [Fixed] - fix listenerCount not resetting for RCTEventEmitter

Test Plan:

I tested this code via a patch in the artsy/eigen app repo: artsy/eigen#13068
The app was using a native module that posts events over the bridge to handle push notifications.

Behavior before:

1. Start app listeners added to ARNotificationManager module, startListener called listenerCount = 2
2. Force a dev reload invalidating the bridge
3. Invalidate called on bridge and the native module causing stopObserving to be called but listenerCount remains 2
4. Bridge refreshes listeners added again but startObserving never called

Behavior after:

1. Start app listeners added to ARNotificationManager module, startListener called listenerCount = 2
2. Force a dev reload invalidating the bridge
3. Invalidate called on bridge and the native module causing stopObserving to be called but listenerCount reset to 0
4. Bridge refreshes listeners added again listeners added again, startObserving called after first

[javache]

Probably not a good idea to have modules that outlive bridge in first place but this seems like unwanted behavior in any case :).

Yes!

No harm in the cleanup though :)

[meta-codesync]

@javache has imported this pull request. If you are a Meta employee, you can view this in D88647586.

[meta-codesync]

@javache merged this pull request in ac8fa25.

[react-native-bot]

This pull request was successfully merged by @brainbicycle in ac8fa25

^{When will my fix make it into a release? | How to file a pick request?}