Fix Dimensions window values on Android < 15 by zoontek · Pull Request #53254 · facebook/react-native

zoontek · 2025-08-13T17:39:24Z

Summary:

⚠️ Note: This relies on #56055 being merged first.

This PR (initially created for edge-to-edge opt-in support, rebased multiple times) fixes the Dimensions API window values on Android < 15, when edge-to-edge is enabled.

Currently the window height doesn't include the status and navigation bar heights (but it does on Android >= 15):

Using WindowMetricsCalculator from AndroidX:

Fixes #47080

Changelog:

[Android] [Fixed] Fix Dimensions window values on Android < 15 when edge-to-edge is enabled

Test Plan:

Run the example app on an Android < 15 device.

facebook-github-bot · 2025-08-14T05:32:29Z

@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D80237818.

react-native-bot · 2025-08-20T12:21:35Z

	Warnings
⚠️	❗ JavaScript API change detected - This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API. Please include a clear changelog message. This change will be subject to extra review. This change was flagged as: `BREAKING`

Generated by 🚫 dangerJS against 6b5397a

facebook-github-bot · 2025-08-28T18:25:02Z

@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D80237818.

alanleedev · 2025-09-01T16:39:42Z

@zoontek There was a question if we could to" keep initDisplayMetrics as a backwards-compat API and have it call both". I haven't quite figured out the internal crash yet. And it does seem like new API does make things bit more fragile. Do you have any thoughts here?

zoontek · 2025-09-02T07:33:13Z

@alanleedev One alternative could be to extract the is UI thread method from AndroidX, set both screen and window dimensions when initDisplayMetrics is called, and only update window dimensions when the context passed is UI context. Not perfect as dimensions might be initialize with screen metrics before switching to window ones, but at least it keeps the same API.

react-native-bot · 2026-03-02T05:20:57Z

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot · 2026-03-02T05:20:57Z

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

zoontek · 2026-03-02T17:58:00Z

As main evolved a lot since I opened this branch, I reworked on it, was able to keep the changes minimal and only compute window dimensions when required.

Montiwa11 · 2026-03-02T18:30:06Z

As main evolved a lot since I opened this branch, I reworked on it, was able to keep the changes minimal and only compute window dimensions when required.

zoontek · 2026-03-03T10:11:13Z

...react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.kt

  }

-  @JvmStatic
-  public fun getDisplayMetricsWritableMap(fontScale: Double): WritableMap {


The methods have been moved to DeviceInfoModule.kt, as they are only used there.

zoontek · 2026-03-03T10:11:57Z

...t-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/DisplayMetricsHolderTest.kt

-  }
-
-  @Test
-  fun getDisplayMetricsWritableMap_returnsCorrectMap() {


This test has been moved to DeviceInfoModuleTest.kt

zoontek · 2026-03-03T10:13:25Z

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/PixelUtilTest.kt

  @Before
  fun setUp() {
    context = RuntimeEnvironment.getApplication()
-    DisplayMetricsHolder.setWindowDisplayMetrics(null)


PixelUtil.kt is not using window display metrics since this commit. Those can be safely removed.

zoontek · 2026-03-03T10:46:14Z

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

-              + notchHeight;
+
+      int heightPixels = getContext().getResources().getDisplayMetrics().heightPixels;
+      final ReactContext reactContext = getCurrentReactContext();


This is the same logic used in DeviceInfoModule.kt getWindowDisplayMetrics, but it has been inlined instead of extracted as a function, since checkForKeyboardEventsLegacy will be deleted here

zoontek · 2026-03-11T18:45:18Z

...s/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.kt

        layout.text,
        layout,
-        DisplayMetricsHolder.getWindowDisplayMetrics(),
+        DisplayMetricsHolder.getScreenDisplayMetrics(),


This is OK, as it's only used for screen density.

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 13, 2025

zoontek force-pushed the fix-dimensions-api branch from 22726c1 to c95b5aa Compare August 13, 2025 17:46

alanleedev requested review from alanleedev, cortinico and javache and removed request for javache August 14, 2025 05:30

zoontek force-pushed the fix-dimensions-api branch from c95b5aa to 47d8ed5 Compare August 20, 2025 10:14

dukenv0307 mentioned this pull request Aug 21, 2025

Mention list is placed at the top of the screen - Gap between mention list and compose box Expensify/App#67651

Closed

8 tasks

zoontek mentioned this pull request Aug 25, 2025

Fix #67651 - Gap between mention list and compose box Expensify/App#69141

Open

52 tasks

react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 2, 2026

zoontek marked this pull request as draft March 2, 2026 10:24

zoontek force-pushed the fix-dimensions-api branch 2 times, most recently from 9e4c7de to 6ccb1ef Compare March 2, 2026 12:28

zoontek marked this pull request as ready for review March 2, 2026 13:31

zoontek force-pushed the fix-dimensions-api branch from 8b4c84a to 84d709e Compare March 2, 2026 21:35

react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 3, 2026

zoontek commented Mar 3, 2026

View reviewed changes

zoontek force-pushed the fix-dimensions-api branch 2 times, most recently from 423f52e to cc6c878 Compare March 11, 2026 13:42

zoontek added 4 commits March 11, 2026 15:32

Fix Dimensions window values on Android < 15

6c22dc6

Pick facebook#56055

4e396a0

Use isEdgeToEdge instead of isEdgeToEdgeFeatureFlagOn

d9986ff

Replace getWindowDisplayMetrics (only used for density here)

9ffbd21

zoontek force-pushed the fix-dimensions-api branch from 9e07deb to 9ffbd21 Compare March 11, 2026 14:32

zoontek commented Mar 11, 2026

View reviewed changes

Conversation

zoontek commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

facebook-github-bot commented Aug 14, 2025

Uh oh!

react-native-bot commented Aug 20, 2025

Uh oh!

facebook-github-bot commented Aug 28, 2025

Uh oh!

alanleedev commented Sep 1, 2025

Uh oh!

zoontek commented Sep 2, 2025

Uh oh!

react-native-bot commented Mar 2, 2026

Uh oh!

react-native-bot commented Mar 2, 2026

Uh oh!

zoontek commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Montiwa11 commented Mar 2, 2026

Uh oh!

zoontek Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

zoontek Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

zoontek Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

zoontek Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zoontek Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zoontek commented Aug 13, 2025 •

edited

Loading

zoontek commented Mar 2, 2026 •

edited

Loading

zoontek Mar 3, 2026 •

edited

Loading