Skip to content

improve disconnection reasons reporting#51227

Closed
vzaidman wants to merge 1 commit into
facebook:mainfrom
vzaidman:export-D74484316
Closed

improve disconnection reasons reporting#51227
vzaidman wants to merge 1 commit into
facebook:mainfrom
vzaidman:export-D74484316

Conversation

@vzaidman
Copy link
Copy Markdown
Contributor

@vzaidman vzaidman commented May 9, 2025

Summary:
Corresponding OS PR:
react/react-native-devtools-frontend#160

Improve termination dialog with the following:

  • Commit 1- add a session ID, if it exists, to the feedback message.
  • Commit 2- add the option to display why devtools got disconnected.
  • Commit 3- add a custom message to be displayed to users in certain cases when a disconnection happens.

Differential Revision: D74484316

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 9, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484316

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484316

…n is closed to debugger (facebook#51227)

Summary:

Standardize error messages thrown from inspector proxy when connection is closed to debugger and link to where they are used in `react-native-devtools-frontend`

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D74484316
@vzaidman vzaidman force-pushed the export-D74484316 branch from 9aa6f71 to 37f459a Compare May 13, 2025 09:36
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484316

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 13, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 9b4be02.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @vzaidman in 9b4be02

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants