-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Update memoryWarning event description to mention it is iOS only #4972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This event is iOS only, and the current documentation does not mention that fact. Also, it incorrectly states that the event fires when when a memory warning is "thrown or released". In fact, there is no event when memory pressure is released. See facebook/react-native#36426 and facebook/react-native#47951
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Simek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chetstone, thanks for making this correction! 👍
Can you also update the corresponding files in versioned docs, located in:
Apply the same changes to all versioned documentation (0.77-0.83): - Add iOS platform label to memoryWarning event - Improve event description clarity
|
Thanks for the quick follow up! Can you fix the lint issues and with that addressed PR should be ready to merge. |
This event is iOS only, and the current documentation does not mention that fact. Also, it incorrectly states that the event fires when when a memory warning is "thrown or released". In fact, there is no event when memory pressure is released.
See facebook/react-native#36426 and facebook/react-native#47951