Fix raw JSON rendering in classifier verdict display#2840
Closed
migeed-z wants to merge 1 commit intofacebook:mainfrom
Closed
Fix raw JSON rendering in classifier verdict display#2840migeed-z wants to merge 1 commit intofacebook:mainfrom
migeed-z wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: I noticed when looking at the classifier output for facebook#2764 that the "verdict" formatting needed to be fixed. Two fixes: 1. formatter.py: Add _format_reason() to render JSON reason dicts as labeled readable sections (e.g. "**Spec check:** ...", "**Reasoning:** ...") 2. llm_client.py: Ensure reason is always a string by serializing dict values, so downstream code handles it consistently. Reviewed By: grievejia Differential Revision: D97422229
grievejia
approved these changes
Mar 21, 2026
Contributor
grievejia
left a comment
grievejia
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 17bf21d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I noticed when looking at the classifier output for #2764 that the "verdict" formatting needed to be fixed.
Two fixes:
labeled readable sections (e.g. "Spec check: ...", "Reasoning: ...")
values, so downstream code handles it consistently.
Reviewed By: grievejia
Differential Revision: D97422229