Handle self type annotation when converting __init__ as a callable
#2226
+69
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
I will take a look! |
stroxler
approved these changes
Jan 27, 2026
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
fangyi-zhou
added a commit
to fangyi-zhou/pyrefly
that referenced
this pull request
Jan 27, 2026
Resolves facebook#2226 Previously, the LSP code completion for overload only shows the closest match. Now it should all overloads that are potentially matching. --- LLM provided summary: Previously, add_kwargs_completions only showed parameters from the single closest-matching overload. Now it shows parameters from all overloads when no arguments have been provided yet, and narrows to the closest match once arguments disambiguate. Also changes get_callables_from_call to return Option<usize> for the overload index, distinguishing a matched overload from no match. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a constructor is converted as a callable, we should take care of any type annotation on the
selfwhen setting the return type of the callable.In particular, the spec says that https://typing.python.org/en/latest/spec/constructors.html#init-method
This diff uses the
selfparameter type to set the return type of the callable to implement this requirement.NOTE: In the conformance test, the callbable converted from constructor is passed around an identical function that causes overload handing to be incorrect. Therefore, this fix does not fix the conformance test in full.
Help needed: There's a regression on
dataclasses_transform_converterconformance test, but I'm unable to make sense of the error. I suspect this is due to some mishandling of generics.Next step: Handle generics correctly when converting constructor into a callable.
Test Plan
test.py