record failed lookups #2202
Open
record failed lookups #2202
+103
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Summary: # This stack This stack modifies the optimization for incremental updates found in the stack containing D90647539. Original optimization: Use import statements alone to understand which imports a module uses Problem: `import foo` will always invalidate `foo` This stack will modify this optimization to instead track these dependencies based on usages during solve. Every type depended on from a module will be referenced in solve and we only will need to invalidate an entire module when there is an import *. # This diff This new API on `LookupExport` allows us to track any time an import or attribute-lookup failed. In the next diff, we will implement it in `state.rs` to add these failed exports to the map. Without these, our incremental system will not know what to invalidate. Note: we have to track all export keys entirely, hence the tests in D91172436. Differential Revision: D91173578
kinto0
force-pushed
the
export-D91173578
branch
from
f103c14 to
95ff062
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This stack
This stack modifies the optimization for incremental updates found in the stack containing D90647539.
Original optimization: Use import statements alone to understand which imports a module uses
Problem:
import foowill always invalidatefooThis stack will modify this optimization to instead track these dependencies based on usages during solve. Every type depended on from a module will be referenced in solve and we only will need to invalidate an entire module when there is an import *.
This diff
This new API on
LookupExportallows us to track any time an import or attribute-lookup failed.In the next diff, we will implement it in
state.rsto add these failed exports to the map. Without these, our incremental system will not know what to invalidate.Note: we have to track all export keys entirely, hence the tests in D91172436.
Differential Revision: D91173578