Skip to content

Conversation

@lexprfuncall
Copy link

This removes duplication introduced by my earlier commit that eliminating the use of the non-standard "+" from BREs in the configure script.

@lexprfuncall lexprfuncall added the cleanup PRs cleaning/refactoring the codebase label Dec 23, 2025
@meta-cla meta-cla bot added the cla signed label Dec 23, 2025
Copy link

@guangli-dai guangli-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the usage of \{1,\} introduce any compatibility concern here? The CI seems to indicate all relatively new OSes (FreeBSD, windows, mac and of course Linux) are all fine with it. But just want to confirm if there are any systems not compatible with this in your mind?

@lexprfuncall
Copy link
Author

lexprfuncall commented Dec 23, 2025

Does the usage of \{1,\} introduce any compatibility concern here? The CI seems to indicate all relatively new OSes (FreeBSD, windows, mac and of course Linux) are all fine with it. But just want to confirm if there are any systems not compatible with this in your mind?

\{1,\} is part of the standard grammar for POSIX BRE so everyone should be fine with it. To validate this change, I tested it on a real grep from UNIX sources (which have no GNU extensions) and it works just fine.

I should have used this idiom to begin with as the replacement for \+ but, at the time, I forgot you could leave out the second number in a bracketed expression. Personally, I mostly use { } in a form like {N} or {N,M} just not {N,}.

This removes duplication introduced by my earlier commit that
eliminating the use of the non-standard "\+" from BREs in the
configure script.
@lexprfuncall lexprfuncall merged commit 7f043be into facebook:dev Dec 24, 2025
155 of 156 checks passed
@lexprfuncall lexprfuncall deleted the bre branch December 24, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed cleanup PRs cleaning/refactoring the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants