fix(core): upgrade serve handler min version to for upgrade users to a secure version#11833
Conversation
resolves security vulnerabilities in minimatch dependency
|
Hi @BearAlliance! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
slorber
left a comment
There was a problem hiding this comment.
LGTM
(the CI error is unrelated, it's due to TS 6.0 being released)
| "react-router-dom": "^5.3.4", | ||
| "semver": "^7.5.4", | ||
| "serve-handler": "^6.1.6", | ||
| "serve-handler": "^6.1.7", |
There was a problem hiding this comment.
agree to do this change, however we are using a ^ range so technically users can already update their lockfile and get the newer version
There was a problem hiding this comment.
Agree. Doing it here alleviates users from having to understand the transitive dependent relationship. In my case, it prevents me from having to add overrides to several repos using the package.
a4646a9 to
bf41a0b
Compare
|
thanks! |
This PR resolves security vulnerabilities in the minimatch dependency.
This is a non-breaking change.
See vercel/serve-handler#228 for details on the security vulnerabilities that were fixed.
Note: minimatch@3.0.5 — pinned exact version, required by @lerna/* and nx. Can't be changed without modifying those packages' dependency declarations. That's a separate concern though.
Pre-flight checklist
Motivation
Resolving security vulnerabilities in transitive dependency.
Test Plan
Existing tests should be sufficient.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
None in this project that I could find.