Skip to content

fix(core): upgrade serve handler min version to for upgrade users to a secure version#11833

Merged
slorber merged 2 commits intofacebook:mainfrom
BearAlliance:upgrade-serve-handler
Mar 24, 2026
Merged

fix(core): upgrade serve handler min version to for upgrade users to a secure version#11833
slorber merged 2 commits intofacebook:mainfrom
BearAlliance:upgrade-serve-handler

Conversation

@BearAlliance
Copy link
Contributor

This PR resolves security vulnerabilities in the minimatch dependency.
This is a non-breaking change.

See vercel/serve-handler#228 for details on the security vulnerabilities that were fixed.

Note: minimatch@3.0.5 — pinned exact version, required by @lerna/* and nx. Can't be changed without modifying those packages' dependency declarations. That's a separate concern though.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Resolving security vulnerabilities in transitive dependency.

Test Plan

Existing tests should be sufficient.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

None in this project that I could find.

resolves security vulnerabilities in minimatch dependency
@meta-cla
Copy link

meta-cla bot commented Mar 23, 2026

Hi @BearAlliance!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@socket-security
Copy link

socket-security bot commented Mar 23, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedserve-handler@​6.1.6 ⏵ 6.1.79910010088100

View full report

@socket-security
Copy link

socket-security bot commented Mar 23, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@netlify
Copy link

netlify bot commented Mar 23, 2026

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit bf41a0b
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/69c29fc8aae4af000854bf05
😎 Deploy Preview https://deploy-preview-11833--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla
Copy link

meta-cla bot commented Mar 23, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Mar 23, 2026
@meta-cla
Copy link

meta-cla bot commented Mar 23, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(the CI error is unrelated, it's due to TS 6.0 being released)

"react-router-dom": "^5.3.4",
"semver": "^7.5.4",
"serve-handler": "^6.1.6",
"serve-handler": "^6.1.7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree to do this change, however we are using a ^ range so technically users can already update their lockfile and get the newer version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Doing it here alleviates users from having to understand the transitive dependent relationship. In my case, it prevents me from having to add overrides to several repos using the package.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 24, 2026
@slorber slorber changed the title Upgrade serve handler fix(core): upgrade serve handler min version to for upgrade users to a secure version Mar 24, 2026
@BearAlliance BearAlliance force-pushed the upgrade-serve-handler branch from a4646a9 to bf41a0b Compare March 24, 2026 14:29
@BearAlliance BearAlliance requested a review from slorber March 24, 2026 14:35
@slorber
Copy link
Collaborator

slorber commented Mar 24, 2026

thanks!

@slorber slorber merged commit f659aef into facebook:main Mar 24, 2026
31 of 45 checks passed
@BearAlliance BearAlliance deleted the upgrade-serve-handler branch March 24, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants