-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
ESM migration: docusaurus-plugin-pwa #11657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
If this PR gets merged i might start migrating other packages. |
|
Thanks This is a public-facing package that users can require, so I'd rather merge this only after we upgrade to Node 22 (https://nodejs.org/en/blog/release/v22.0.0) because not supporting Although in practice I doubt many users do |
Pre-flight checklist
Motivation
ESM migration for docusaurus-plugin-pwa package.
Note: i would appreciate some feedback.
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs