bootstrap: add windows dotslash shims #970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
Author
|
In the interests of security (i.e. randomly committing executables in the wake of lzma-gate): Which was committed upstream by a Meta employee in facebookincubator/reindeer@f052264. |
thoughtpolice
force-pushed
the
aseipp/push-ztorynssvzpz
branch
9 times, most recently
from
9e74b7e to
b3e370d
Compare
Contributor
Author
|
I actually included the wrong shim :) The one from the reindeer repository is 13KB, an earlier build, while the one in https://github.com/zsol/dotslash/blob/windows-no-std-shim/windows_shim/dotslash_windows_shim-x86_64.exe from facebook/dotslash#46 actually is 4KB. Replaced. Updated paranoia check: |
Contributor
Author
|
By the way, once this is merged, all you have to do is: $env:Path += ";$((Get-Item .).FullName)\bootstrap"In any buck2 checkout and now |
thoughtpolice
force-pushed
the
aseipp/push-ztorynssvzpz
branch
3 times, most recently
from
1305db9 to
d67fa69
Compare
I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
aseipp/push-ztorynssvzpz
branch
from
d67fa69 to
54d99ae
Compare
Contributor
|
Guessing this is also needing the same treatment @bigfootjon did for the other dotslash files. Checking with him. |
alexlian
added
buck2 development
Member
|
Nah we're good here, discussed over chat but we don't really need to keep these files up to date |
bigfootjon
approved these changes
May 30, 2025
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
Contributor
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
May 30, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
vmagro
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Sep 2, 2025
Summary: I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier. X-link: facebook/buck2#970 Reviewed By: bigfootjon Differential Revision: D75533918 Pulled By: alexlian fbshipit-source-id: 1d7cccfe49cd1dcec009835c64f3df792997cf75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the WIP 4kb dotslash shim (from DotSlash PR 46) for a while now and it seems usable enough. They're already in use by Reindeer, too. Let's add these to make Windows bootstraps a bit easier.