gc2: es: Add delay to filter false SYS_THROTTLE SEL#2728
Open
Joseph-Shih-ww wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D106637548. (Because this pull request was imported automatically, there will not be any future comments.) |
[Task Description] Related to GC20T5T7-182 Add a 1 ms delayed work handler for SYS_THROTTLE interrupt handling. [Motivation] FM_CPU_BIC_PROCHOT_LVT3_N may have a short transient pulse during the power-off transition. This transient pulse could trigger a false SYS_THROTTLE SEL event. [Design] Move SYS_THROTTLE SEL logging to a delayed work handler. Delay 1 ms before rechecking RST_PLTRST_PLD_N, PWRGD_SYS_PWROK, and FM_CPU_BIC_PROCHOT_LVT3_N. Only add the SYS_THROTTLE SEL when the power/reset signals are still in a valid state after the delay. [Test Log] During the power-off transition, the false SYS_THROTTLE SEL event can be filtered by the 1 ms delayed check. Normal SYS_THROTTLE ASSERT/DEASSERT behavior is still reported as expected. 1.Executing 12V-cycle ``` power-util server 12V-cycle ``` 2.Verify that throttle-related logs are recorded during the test. ``` root@bmc-oob:~# log-util all --print |grep SYS_THROTTLE root@bmc-oob:~# ```
JimLin-ww
force-pushed
the
Joseph/fbgc2-es/Jira202_Fix_sv_status
branch
from
481de5a to
24f8032
Compare
|
@Joseph-Shih-ww has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Task Description]
Related to GC20T5T7-182
Add a 1 ms delayed work handler for SYS_THROTTLE interrupt handling.
[Motivation]
FM_CPU_BIC_PROCHOT_LVT3_N may have a short transient pulse during the power-off transition. This transient pulse could trigger a false SYS_THROTTLE SEL event.
[Design]
Move SYS_THROTTLE SEL logging to a delayed work handler. Delay 1 ms before rechecking RST_PLTRST_PLD_N, PWRGD_SYS_PWROK, and FM_CPU_BIC_PROCHOT_LVT3_N. Only add the SYS_THROTTLE SEL when the power/reset signals are still in a valid state after the delay.
[Test Log]
During the power-off transition, the false SYS_THROTTLE SEL event can be filtered by the 1 ms delayed check. Normal SYS_THROTTLE ASSERT/DEASSERT behavior is still reported as expected.
1.Executing 12V-cycle
2.Verify that throttle-related logs are recorded during the test.