Skip to content

sb: rb: remove unused log and add multiple new functions#2723

Open
khoung76642 wants to merge 33 commits into
facebook:mainfrom
khoung76642:upcode_sb-rb-20262001
Open

sb: rb: remove unused log and add multiple new functions#2723
khoung76642 wants to merge 33 commits into
facebook:mainfrom
khoung76642:upcode_sb-rb-20262001

Conversation

@khoung76642
Copy link
Copy Markdown
Contributor

Summary:

  • add patch 0034-NUVOTON i2c-npcm4xx-handle-SLVSTP-and-NMATCH-events-in-maste
  • add patch 0035-boards-npcm400f_evb-enable-pwm2-with-open-drain-outp
  • Remove ASIC version info shown in MMC console when getting PLDM version request
  • modify gpio ASIC pin for asic_type
  • add checking bootstrap pin setting black box event and send to BMC
  • move FM_PLD_UBC_EN handling from GPIO ISR to CPLD polling
  • modify power_capping_control shell command display
  • is_ubc_enable status source changed from GPIO to CPLD register
  • Remove Asic boot1 update function and modified malloc size
  • remove hamsa_avdd_pcie code
  • remove unuse code with plat_def
  • Optimize the bootstrap event log detection logic
  • add 100MHz, 312.5MHz, 100MHz buf0/1/2 clk lock event
  • fix ubc delay check
  • modified after vr power fault will keep polling status
  • add lv2, lv3 thermal protection functions
  • fix check power capping time condition logic
  • add EVB board will not support 0xA8 Asic temp thermal protection
  • modified pwr capping lv1 threshold user can set current(i2c target 0x90 also changed)
  • Set CNV*2 and CS1 high before ADC initialization to prevent simultaneous CS0/CS1 low, which may cause incorrect ADC register reads and affect ADC initialization.
  • Add clock 312.5MHz re-init function(0x00A8, 0x0080, 0x0088, 0x0D00)
  • Modify asic_type decision on EVB
  • Modify EVB BOARD_STAGE show words
  • Modify LEVEL1 time_window range 10-100 us(shell and i2c target)-jira-933
  • Add polling ASIC HAMSA version every 5s until get the correct version.If get version(not 0 or 0xFFFFFF) set GPIO I3C_RAINBOW_ALERT_N to high to notify BMC.-jira-1440.

Test Plan:

  • Build code: Pass

YoungLi123 and others added 30 commits May 22, 2026 10:08
Summary:
- add NUVOTON i2c-npcm4xx-handle-SLVSTP-and-NMATCH-events-in-maste

Test Plan:
- Stress over weekend
Summary:
- modify asic_type decision
- implement jira-1415

TestPlan:
Build code: Pass
…n-maste

Summary:
- reorder NUVOTON i2c-npcm4xx-handle-SLVSTP-and-NMATCH-events-in-maste
Summary:
- Version commit for sb-rb-20261601

Test Plan:
Build code: Pass
Summary:
- Version commit for sb-rb-20261801

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20261701

Test Plan:
- Build code: Pass
Summary:
- add lv2, lv3 thermal protection functions
- fix check power capping time condition logic

Test Plan:
- Build code: Pass
Summary:
- add 100MHz, 312.5MHz, 100MHz buf0/1/2 clk lock event
- fix ubc delay check

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20261801

Test Plan:
- Build code: Pass
…current

Summary:
- modified pwr capping lv1 threshold user can set current(i2c target 0x90 also changed)
- Set CNV*2 and CS1 high before ADC initialization to prevent simultaneous CS0/CS1 low, which may cause incorrect ADC register reads and affect ADC initialization.

Test Plan:
- Build code: Pass
Summary:
- Add clock 312.5MHz re-init function(0x00A8, 0x0080, 0x0088, 0x0D00)

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20261901

Test Plan:
- Build code: Pass
Summary:
- Modify asic_type  decision on EVB
- Modify EVB BOARD_STAGE show words

Test Plan:
- Build code: Pass
…rsion every 5s to set GPIO I3C_RAINBOW_ALERT_N pin

Summary:
- Modify LEVEL1 time_window range 10-100 us(shell and i2c target)-jira-933
- Add polling ASIC HAMSA version every 5s until get the correct version.If get version(not 0 or 0xFFFFFF) set GPIO I3C_RAINBOW_ALERT_N to high to notify BMC.-jira-1440.

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20262001

Test Plan:
- Build code: Pass
LisaChang-Quanta and others added 2 commits May 22, 2026 16:20
Summary:
- remove unuse LOG_DBG message

Test Plan:
- Build code: PASS
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2026
@facebook-github-tools
Copy link
Copy Markdown

@khoung76642 has updated the pull request. You must reimport the pull request before landing.

@khoung76642
Copy link
Copy Markdown
Contributor Author

1.For cpp check error
common/hal/hal_i2c.c:91:2:Assignment of function parameter has no effect outside the function.
common/hal/hal_i2c.c:412:6:Unused variable: status
common/hal/hal_i2c.c:104:23:Expression is always true because 'else if' condition is opposite to previous condition at line 101.
We have reviewed these cppcheck warnings and confirmed that they are all false positives.

2.For clang-format error
meta-facebook/sb-rb/src/platform/plat_hamsa_avdd_pcie.c has clang-format errors!
meta-facebook/sb-rb/src/platform/plat_hamsa_avdd_pcie.h has clang-format errors!
These two files has been delete so it should be ok.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 22, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D106060926. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants