Skip to content

op2: gl: plat_pmic: Revise PMIC VIN_BULK_OV error pattern#2721

Open
JayZhang-wiwynn wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Unive/op2/revise-pmic-ov-error
Open

op2: gl: plat_pmic: Revise PMIC VIN_BULK_OV error pattern#2721
JayZhang-wiwynn wants to merge 1 commit into
facebook:mainfrom
Wiwynn:Unive/op2/revise-pmic-ov-error

Conversation

@JayZhang-wiwynn
Copy link
Copy Markdown
Contributor

Description

Revise PMIC VIN_BULK_OV error pattern to align with the correct PMIC specifications

Motivation

The previous PMIC VIN_BULK_OV error pattern was incorrect, which could lead to redundant error reporting and confusion during debugging. By updating the error pattern to the correct one, we can ensure accurate error detection and improve the reliability of the system.

Test Plan

  1. Compile the firmware with the updated PMIC VIN_BULK_OV error pattern.
  2. Deploy the firmware to the target device.
  3. inject each PMIC error, including VIN_BULK_OV, and verify that the correct error pattern is reported for each case.

Test Results

All PMIC errors, including VIN_BULK_OV, were correctly detected and reported with the updated error pattern, confirming the successful revision of the PMIC VIN_BULK_OV error pattern.

# Description
Revise PMIC VIN_BULK_OV error pattern to align with the correct PMIC
specifications

# Motivation
The previous PMIC VIN_BULK_OV error pattern was incorrect, which could
lead to redundant error reporting and confusion during debugging.
By updating the error pattern to the correct one, we can ensure accurate
error detection and improve the reliability of the system.

# Test Plan
1. Compile the firmware with the updated PMIC VIN_BULK_OV error pattern.
2. Deploy the firmware to the target device.
3. inject each PMIC error, including VIN_BULK_OV, and verify that the
   correct error pattern is reported for each case.

# Test Results
All PMIC errors, including VIN_BULK_OV, were correctly detected and
reported with the updated error pattern, confirming the successful
revision of the PMIC VIN_BULK_OV error pattern.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 19, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D105664702. (Because this pull request was imported automatically, there will not be any future comments.)

@UniveTien
Copy link
Copy Markdown
Contributor

Note: The CI was failed on a platform that was irrelevant to the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants