-
Notifications
You must be signed in to change notification settings - Fork 357
Noise module #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Noise module #4760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 13, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
==========================================
+ Coverage 96.72% 96.73% +0.01%
==========================================
Files 583 585 +2
Lines 60860 61008 +148
==========================================
+ Hits 58866 59017 +151
+ Misses 1994 1991 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 13, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
1cb7d9c to
5aaaa01
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 13, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
5aaaa01 to
f6f8cca
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#4760 T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
f6f8cca to
db5784f
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
Summary: Per discussion in D90596997 Differential Revision: D90777058
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997 Privacy Context Container: L1413903
db5784f to
4ec7658
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 15, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997 Privacy Context Container: L1413903
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 15, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997 Privacy Context Container: L1413903
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 16, 2026
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Reviewed By: saitcakmak Differential Revision: D90596997 Privacy Context Container: L1413903
|
This pull request has been merged in ebdf363. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
fb-exported
Merged
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
T249209321
Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.
Adds two noise implementations:
GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems
Subsequent diff migrates current benchmarking to incorporate these changes.
Differential Revision: D90596997