Skip to content

Conversation

@hvarfner
Copy link

Summary:
T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 13, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 13, 2026

@hvarfner has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90596997.

hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 13, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.73%. Comparing base (7bce65b) to head (4ec7658).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4760      +/-   ##
==========================================
+ Coverage   96.72%   96.73%   +0.01%     
==========================================
  Files         583      585       +2     
  Lines       60860    61008     +148     
==========================================
+ Hits        58866    59017     +151     
+ Misses       1994     1991       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 13, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 13, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:
Pull Request resolved: facebook#4760

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 14, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision: D90596997
Carl Hvarfner added 2 commits January 15, 2026 12:30
Summary:

Per discussion in D90596997

Differential Revision: D90777058
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision:
D90596997

Privacy Context Container: L1413903
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 15, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision:
D90596997

Privacy Context Container: L1413903
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 15, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Differential Revision:
D90596997

Privacy Context Container: L1413903
hvarfner pushed a commit to hvarfner/Ax that referenced this pull request Jan 16, 2026
Summary:

T249209321

Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction.

Adds two noise implementations:

GaussianNoise - standard IID Gaussian noise with configurable noise_std
GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems 

Subsequent diff migrates current benchmarking to incorporate these changes.

Reviewed By: saitcakmak

Differential Revision:
D90596997

Privacy Context Container: L1413903
@meta-codesync meta-codesync bot closed this in ebdf363 Jan 16, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 16, 2026

This pull request has been merged in ebdf363.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants