-
Notifications
You must be signed in to change notification settings - Fork 357
Extract early stopping message constants and helpers to OSS #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+321
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90404643. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4751 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 582 583 +1
Lines 60809 60856 +47
=======================================
+ Hits 58818 58864 +46
- Misses 1991 1992 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
2bbbd62 to
3e8d863
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
3e8d863 to
539dac3
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 12, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
539dac3 to
0f328de
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 12, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
0f328de to
1a822a7
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 13, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Differential Revision: D90404643
1a822a7 to
749ce80
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Extracts shared early stopping message constants and formatting logic to the OSS `ax/early_stopping/utils.py` module. Reviewed By: bernardbeckerman Differential Revision: D90404643
749ce80 to
2794bfe
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Extracts shared early stopping message constants and formatting logic to the OSS `ax/early_stopping/utils.py` module. Reviewed By: bernardbeckerman Differential Revision: D90404643
2794bfe to
7712253
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
…#4751) Summary: Pull Request resolved: facebook#4751 Extracts shared early stopping message constants and formatting logic to the OSS `ax/early_stopping/utils.py` module. Reviewed By: bernardbeckerman Differential Revision: D90404643
7712253 to
f6bd21c
Compare
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
Summary: Pull Request resolved: facebook#4745 Reviewed By: bernardbeckerman Differential Revision: D90035967 Privacy Context Container: L1307644
…#4751) Summary: Extracts shared early stopping message constants and formatting logic to the OSS `ax/early_stopping/utils.py` module. Reviewed By: bernardbeckerman Differential Revision: D90404643
f6bd21c to
1fa58f1
Compare
|
This pull request has been merged in 48b65c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
fb-exported
Merged
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D90404643