-
Notifications
You must be signed in to change notification settings - Fork 357
Extract early stopping replay utilities to OSS #4744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90150341. |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 6, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 6, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
c1ce45e to
d1b20e5
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 6, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4744 +/- ##
==========================================
- Coverage 96.72% 96.72% -0.01%
==========================================
Files 582 583 +1
Lines 60809 60857 +48
==========================================
+ Hits 58818 58864 +46
- Misses 1991 1993 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 7, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 7, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
d1b20e5 to
d0dde1d
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
d0dde1d to
1a5d934
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
1a5d934 to
9f40eac
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
9f40eac to
177cfd2
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Key changes: - Added `estimate_hypothetical_early_stopping_savings()` to `experiment_replay.py` which combines `get_default_ess_or_none()`, `replay_experiment()`, and `estimate_early_stopping_savings()` into a single utility - Added constants `MAX_REPLAY_TRIALS`, `REPLAY_NUM_POINTS_PER_CURVE`, and `MAX_PENDING_TRIALS` to `experiment_replay.py` - Added optional `minimize` parameter to `replay_experiment()` to explicitly control optimization direction - Updated `ax_sweep_orchestrator.py` to use the new `estimate_hypothetical_early_stopping_savings()` function - Added unit tests for the new function in `test_experiment_replay.py` Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
177cfd2 to
a514410
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
a514410 to
7568d2d
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
7568d2d to
43bff93
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 9, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
43bff93 to
82dba08
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 12, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
82dba08 to
c1287d1
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 12, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
c1287d1 to
530e212
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 13, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 13, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
530e212 to
91b0c73
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 13, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
91b0c73 to
98e662f
Compare
shrutipatel31
pushed a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#4744 Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341
98e662f to
365498d
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
shrutipatel31
pushed a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#4744 Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341 Reviewed By: bernardbeckerman
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
365498d to
b460457
Compare
shrutipatel31
pushed a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#4744 Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341 Reviewed By: bernardbeckerman
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
b460457 to
e0b3a74
Compare
shrutipatel31
pushed a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Pull Request resolved: facebook#4744 Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Differential Revision: D90150341 Reviewed By: bernardbeckerman
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
e0b3a74 to
49ac9f3
Compare
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
49ac9f3 to
4aa249c
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Adds the `estimate_hypothetical_early_stopping_savings()` function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy. Reviewed By: bernardbeckerman Differential Revision: D90150341
|
This pull request has been merged in 10dd3e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
fb-exported
Merged
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds the
estimate_hypothetical_early_stopping_savings()function to the OSS module. This function estimates potential compute savings by replaying an experiment with a default early stopping strategy.Differential Revision: D90150341