[Python] Add HashSet and NestedPattern tests, fix HashSet operations for native sets#4345
Open
[Python] Add HashSet and NestedPattern tests, fix HashSet operations for native sets#4345
Conversation
…for native sets The Python HashSet replacements were using JS method names (has, delete) that don't exist on Python's native set type. Fixed Count, Contains, Remove, UnionWith, IntersectWith, and ExceptWith to use Python-compatible helpers that work with both native set and custom MutableSet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
dbrattli
force-pushed
the
dbrattli/fable-python-more-tests
branch
from
da80512 to
f0e37de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python HashSet replacements were using JS method names (has, delete) that don't exist on Python's native set type. Fixed Count, Contains, Remove, UnionWith, IntersectWith, and ExceptWith to use Python-compatible helpers that work with both native set and custom MutableSet.