Rust - Support [<Emit(type)>] on a type to assist with binding to built in types#2904
Merged
ncave merged 2 commits intofable-compiler:snake_islandfrom May 29, 2022
Merged
Conversation
alexswan10k
changed the title
alexswan10k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from @ncave's suggestion covered here , and @alfonsogarciacaro's dart spike, this expands the Emit attribute to be supported on types, which will then be output as type decorators when required (function parameters, let bindings, struct definitions, etc).
I have made the design choice to not include any of the wrapped types and let a creator of the binding have full control over this, which also ensures consistency with any create method etc.