Skip to content

Monolith onboarding#428

Open
timcowlishaw wants to merge 6 commits intomasterfrom
monolith-onboarding
Open

Monolith onboarding#428
timcowlishaw wants to merge 6 commits intomasterfrom
monolith-onboarding

Conversation

@timcowlishaw
Copy link
Copy Markdown
Contributor

@timcowlishaw timcowlishaw commented Oct 15, 2025

This I think is now ready for review, @oscgonfer! There's doubtless a few enhancements to make and wrinkles to sort out, but it should work end to end for now.

This adds the new onboarding page (unlinked, for now) at /ui/devices/onboarding, allowing multiple devices to be registered at once.

It also fixes a bug where a javascript error would halt execution on a device page if the device has no execution set, and adds the ability for users to search for locations in the map picker widget wherever it's used, rather than just clicking.

I had to upgrade a couple of dependencies which have since been deprecated- in particular the docker image for openJDK8 on which kairos runs. therefore, We should test througourhly that data is being ingested and querying of readings work on staging, even though it's not directly related to the onboarding.

A couple of things I know we still need to add:

  • Linking this into the rest of the UI properly, including the existing start.smartcitizen flow.
  • Adding the ability to add multiple additional devices to the list at once
  • (possible stretch goal) - adding all devices to a new experiment on registration

A couple of things I think we might have to think some more about:

  • Giving more explicit instructions around how to use the device token, and how to recover from errors there.
  • I think we need to finesse the layout a bit to make the boundaries between each device in the list more obvious, and make it easier to see a summary of which devices have been added.

See: https://staging-api.smartcitizen.me/ui/devices/onboarding

@timcowlishaw timcowlishaw requested a review from oscgonfer March 24, 2026 13:12
@oscgonfer
Copy link
Copy Markdown
Collaborator

Hi @timcowlishaw

Just looking into what kind of testing we need to do for the OpenJDK upgrade. Is this not covered as part of our current unit tests?

Would it be enough to send some mqtt payloads and check alignment with REST API requests? Or do you think we need more (csv upload, direct post requests...)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants