Open
Conversation
Collaborator
|
Just looking into what kind of testing we need to do for the OpenJDK upgrade. Is this not covered as part of our current unit tests? Would it be enough to send some mqtt payloads and check alignment with REST API requests? Or do you think we need more (csv upload, direct post requests...)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This I think is now ready for review, @oscgonfer! There's doubtless a few enhancements to make and wrinkles to sort out, but it should work end to end for now.
This adds the new onboarding page (unlinked, for now) at /ui/devices/onboarding, allowing multiple devices to be registered at once.
It also fixes a bug where a javascript error would halt execution on a device page if the device has no execution set, and adds the ability for users to search for locations in the map picker widget wherever it's used, rather than just clicking.
I had to upgrade a couple of dependencies which have since been deprecated- in particular the docker image for openJDK8 on which kairos runs. therefore, We should test througourhly that data is being ingested and querying of readings work on staging, even though it's not directly related to the onboarding.
A couple of things I know we still need to add:
A couple of things I think we might have to think some more about:
See: https://staging-api.smartcitizen.me/ui/devices/onboarding