fix(typescript): Handle invalid type names

[sschw]

I recently saw that there is an issue with certain names in the schema.

components:
  responses:
    "400":
      description: Bad request

The schema above will generate the definition export type 400 = void where 400 is an invalid identifier.

The problem happens in schemaToTypeAliasDeclaration as the name is used without any check for its validity.

I addressed this issue by prepending invalid names by _ and if they are still invalid, by removing any non A-Za-z0-9 characters.

It might cause collisions though if you have e.g. 400 and _400, or you use a schema full of e.g. emojis as names.

[triglian]

+1

[fabien0102]

Interesting edge case, let’s try to make it even more fancy for the number only (the function is already there)

[fabien0102]

For the case where it’s only numbers, we could use this

openapi-codegen/plugins/typescript/src/utils/getEnumProperties.ts

Line 95 in c555865

export const convertNumberToWord = (n: number): string => {

[sschw]

We could name it here "NoValidName" or we use the invalid name here.

I just kept the "_" as placeholder.

[sschw]

This check will also convert "0123" to "OneTwoThree", as it can convert it to a number.

What do you prefer? Either we ignore this, add a handling for "Zero" at the start or we let the check fail and handle this case in the "else"-block

[fabien0102]

Should be fine without the "Zero" handling.