Various improvements to control modes, Added in braking. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using std::thread for rxThread
Add current control to vesc driver
Add current control to vesc driver
Fix if comparison.
Removed old code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port of this package to ROS2 omitted several features, including braking and acceleration based control.
I've added these back in with some changes, including a parametrized braking curve and early starting velocity smoothing to prevent stuttering.
This is best coupled with the updated motor configuration file, included herein, which has setup for the VESC's HFI capabilities.
The nested if-else statements could almost certainly be improved, but seems to work well enough.
The acceleration based control part is largely untested and does not allow for reverse, but this could be remedied pretty easily. I really do not recommend using this operation mode unless you know what you are doing RE figuring out how much current your car requires to accelerate.
For an example vesc.yaml, see this config folder.
If I have some time after graduation I'll improve the robustness/speed of the if-else stack and do some testing to see how the acceleration based portion works in real life.