detect upstream-merged PRs closed by commit#3
Open
fematarazzo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects (Vim, Linux, Git) don't use GitHub's native merge button — maintainers cherry-pick changes and close the PR with a reference commit. GitHub marks these as CLOSED with mergedAt: null, so they were being counted as rejected.
This adds timelineItems to the GraphQL query to fetch the ClosedEvent.closer on each PR. If the closer is a Commit, the PR was applied upstream and is now counted as merged in stats. The merged_date is set from closedAt in those cases.
Changes: