Lowercase mod checks. #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| LOG(WARNING) << "String size_t const exceeds maximum signed integer size. Overflow immenent."; // For the rare, rare case that this may occur. | ||
| } | ||
|
|
||
| intLength = static_cast<int>(length); |
Contributor
There was a problem hiding this comment.
why do you need to cast to int? For loops work fine with size_t
Contributor
Author
There was a problem hiding this comment.
Size_t conversions to int produce compiler warnings.
"warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data"
Contributor
There was a problem hiding this comment.
http://sprunge.us/iaNL?diff
This compiles 100% fine, no compile warnings. You'll get a warning if you define i as an int instead of size_t, but it's perfectly valid to use size_t.
Contributor
|
getLower can (and probably should) be implemented using setLower (DRY!), and you don't need to be casting from int. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe? I'm sure it'd help a lot of people!