-
Notifications
You must be signed in to change notification settings - Fork 5
[DNM] Move from hand-written makefiles to CMake #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'm not that bothered by a lack of PCH. The total build time is low enough that it shouldn't be of major impact. |
|
The project is vaguely structured around the |
|
Code looks good, and the licenses appear to be compatible with the BSD license of the chat server. Is there a way to include Cotire without placing it in the repo directly? Perhaps through a git subtree, or through a travis step? My main objection to the previous set up was that it was included as part of the repo directly. |
.travis.yml
Outdated
| - cd ~/build/f-list/fserv | ||
| - make all | ||
| - cd $HOME/build/$TRAVIS_REPO_SLUG | ||
| - cmake . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should use a dedicated build directory. In tree building with CMake is discouraged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
|
A subtree is part of the repo, just easily updated to an external repo. A submodule is possible. Travis step is also reasonable, but I'll need to double check to make sure I can conditionally run cotire. |
|
If it can be easily pulled in, and isn't part of the repo, it doesn't need to be conditional. Having it conditional might be useful, but isn't a requirement. |
|
We'll see how travis likes it, but this should make cotire an optional, submodule-ed dep. |
|
It doesn't. Looks like it's because I'm using an ssh url for the submodule. Fixing. |
744b4e8 to
15c2f25
Compare
Optionally uses cotire. Travis now runs on trusty.
Just putting this up to get more feedback on it.
Now compiles on systems with recent gperftools! Woo!
Currently this doesn't do precompiled headers, there's a CMake module that works great for them but it was deemed a bit much to be adding.
Current todo: