Skip to content

Document full test suite runtime #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ezyang wants to merge 7 commits into from
+4 −0
Closed

Document full test suite runtime #351

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0e7287
Update
ezyang May 11, 2026
699b6ba
Update
ezyang May 11, 2026
17466ca
Update
ezyang May 11, 2026
aac342d
Update
ezyang May 11, 2026
7451688
Update
ezyang May 11, 2026
5c0dea8
Update
ezyang May 11, 2026
01d8497
Update
ezyang May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

Run `python -m black src/ghstack/` and `python -m flake8 src/ghstack/` to fix and check lint before committing. If lint fixes are needed after a commit, amend the commit rather than creating a separate lint fix commit.

## Tests

The full test suite takes quite a long time to run. Prefer focused tests while iterating, and only run the full suite when the change is otherwise done.

## ghstack trailers

When rewriting, splitting, rebasing, or autosquashing a ghstack stack, preserve existing `ghstack-source-id`, `ghstack-comment-id`, and `Pull-Request` trailers on each logical commit. Before submitting a rewritten stack, compare commit messages against the saved/pre-rewrite commits or search local history for an existing `Pull-Request` trailer with the same subject. If a logical commit was already submitted, keep its existing `Pull-Request` and `ghstack-comment-id` instead of letting ghstack create a new PR.
Loading